Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc 9.10 #5

Merged
merged 1 commit into from
May 30, 2024
Merged

Make it build with ghc 9.10 #5

merged 1 commit into from
May 30, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented May 21, 2024

No description provided.

@AndreasPK
Copy link
Owner

If you fix the conflict I'm happy to merge this.

@erikd
Copy link
Contributor Author

erikd commented May 23, 2024

Conflict fixed. Hacakge update (even just a metadata edit) would be appreciated as well.

@AndreasPK
Copy link
Owner

I will wait for ci to pass just in case. Should I get distracted feel free to ping me once it's passed.

Hacakge update (even just a metadata edit) would be appreciated as well.

I hope to update it similarly once CI is green for that.

@erikd
Copy link
Contributor Author

erikd commented May 23, 2024

CI still had not run when I looked at it this morning so I touched the top commit and force pushed hoping to get it picked up by the runner. Now its waiting for you to approve it.

@AndreasPK
Copy link
Owner

I think the free CI is just overloaded with many people updating things for 9.10 currently. CI hasn't run for my last commit on master yet either.

@erikd
Copy link
Contributor Author

erikd commented May 26, 2024

@AndreasPK According to my view this PR still has "1 workflow awaiting approval". I think there is a button somewhere for you to press (but I do not see it).

@AndreasPK
Copy link
Owner

@AndreasPK According to my view this PR still has "1 workflow awaiting approval". I think there is a button somewhere for you to press (but I do not see it).

Yes, I had approved but I think it reset when you force pushed to your master branch. Re-approved and let's see if ci is faster now :D The run on master timed out since no runner was found in 24 hours ❌ But that shouldn't affect the MR

@AndreasPK
Copy link
Owner

But looking at other repos using haskell-ci i suspect I might have to update the config for the jobs to get picked up.

@AndreasPK
Copy link
Owner

Well your changes to me seem trivial and correct so I won't make the CI issue your problem.

@AndreasPK AndreasPK merged commit 28c569e into AndreasPK:master May 30, 2024
0 of 8 checks passed
@erikd
Copy link
Contributor Author

erikd commented May 31, 2024

Thanks. Would also greatly appreciate a Hackage metadata edit.

@AndreasPK
Copy link
Owner

[> Thanks. Would also greatly appreciate a Hackage metadata edit.

](https://hackage.haskell.org/package/dom-lt-0.2.3/revisions/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants