-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it build with ghc 9.10 #5
Conversation
If you fix the conflict I'm happy to merge this. |
Conflict fixed. Hacakge update (even just a metadata edit) would be appreciated as well. |
I will wait for ci to pass just in case. Should I get distracted feel free to ping me once it's passed.
I hope to update it similarly once CI is green for that. |
CI still had not run when I looked at it this morning so I touched the top commit and force pushed hoping to get it picked up by the runner. Now its waiting for you to approve it. |
I think the free CI is just overloaded with many people updating things for 9.10 currently. CI hasn't run for my last commit on master yet either. |
@AndreasPK According to my view this PR still has "1 workflow awaiting approval". I think there is a button somewhere for you to press (but I do not see it). |
Yes, I had approved but I think it reset when you force pushed to your master branch. Re-approved and let's see if ci is faster now :D The run on master timed out since no runner was found in 24 hours ❌ But that shouldn't affect the MR |
But looking at other repos using haskell-ci i suspect I might have to update the config for the jobs to get picked up. |
Well your changes to me seem trivial and correct so I won't make the CI issue your problem. |
Thanks. Would also greatly appreciate a Hackage metadata edit. |
[> Thanks. Would also greatly appreciate a Hackage metadata edit. ](https://hackage.haskell.org/package/dom-lt-0.2.3/revisions/) |
No description provided.